-
Type: Bug
-
Status: Resolved (View Workflow)
-
Priority: Medium
-
Resolution: Done
-
Affects Version/s: VOLTHA v2.7
-
Fix Version/s: VOLTHA v2.7
-
Component/s: omci-lib-go, openonu-adapter
-
Labels:None
-
Story Points:3
-
Epic Link:
func (omci *EndSoftwareDownloadRequest) SerializeTo(...) does not work and leads to a crash.
Apart from the handling of further Instances as discussed above for the StartSoftwareDownload, obviously the correct relevant code fragment should be:
binary.BigEndian.PutUint32(bytes[0:4], omci.CRC32)
binary.BigEndian.PutUint32(bytes[4:8], omci.ImageSize)
bytes[8] = omci.NumberOfInstances
for index := 0; index < int(omci.NumberOfInstances); index++
Also serializing for EndSoftwareDownloadResponse looks a bit to far-going, but at least it seems to be usable.
# | Subject | Branch | Project | Status | CR | V |
---|---|---|---|---|---|---|
23026,3 | VOL-3863: Bugfix to EndSoftwareDownloadRequest serialization/decode | master | omci-lib-go | Status: MERGED | +2 | +1 |