Uploaded image for project: 'VOLTHA'
  1. VOLTHA
  2. VOL-3863

EndSoftwareDownloadRequest missing serialisation

    XMLWordPrintable

    Details

      Description

      func (omci *EndSoftwareDownloadRequest) SerializeTo(...) does not work and leads to a crash.
      Apart from the handling of further Instances as discussed above for the StartSoftwareDownload, obviously the correct relevant code fragment should be:
      binary.BigEndian.PutUint32(bytes[0:4], omci.CRC32)
      binary.BigEndian.PutUint32(bytes[4:8], omci.ImageSize)
      bytes[8] = omci.NumberOfInstances
      for index := 0; index < int(omci.NumberOfInstances); index++

      { binary.BigEndian.PutUint16(bytes[9+(index*2):], omci.ImageInstances[index]) }

      Also serializing for EndSoftwareDownloadResponse looks a bit to far-going, but at least it seems to be usable.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            cboling Chip Boling
            Reporter:
            andrea Andrea Campanella
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes