Uploaded image for project: 'VOLTHA'
  1. VOLTHA
  2. VOL-5309

repo:votlha-go-controller cleanups

    XMLWordPrintable

    Details

    • Type: Task
    • Status: To Do (View Workflow)
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: voltha-go-controller
    • Labels:
      None
    • Story Points:
      0

      Description

      https://gerrit.opencord.org/plugins/gitiles/voltha-go-controller/+/refs/heads/master/Makefile

      1. Add a project copyright notice spanning 2022-2024
        1. https://github.com/joey-onf/copyright/blob/origin/master/notice
      2. Remove sudo calls [target:build-docker-profile|sudo docker build -t $(IMAGENAME)-profile -f docker/Dockerfile.voltha-go-controller .]
        • Jenkins does not run as a privileged user.
        • Sudo can be a potential failure source for build automation.
        • sudo vs not-required/account has privs – can produce variant behavior.
      3. https://gerrit.opencord.org/plugins/gitiles/onf-make/+/refs/heads/master/makefiles/docker/include.mk  repo:onf-make/makefiles/lint/docker/
        1. Consider makefile refactoring.
        2. Most golang and docker logic is available for free from existing library makefile targets.
      4. Review $(is-stdin) logic in docker/include.mk.  When docker is passed common flags (-it) to attach stdin, stdout & stdder – it will prevent docker from directing output where jenkins can capture it for logging:
        1. is-stdin = $(shell test -t 0 && { echo '--interactive'; }

          )

          is-stdin += --tty

       

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            joey Joey Armstrong
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes