-
Type: Task
-
Status: To Do (View Workflow)
-
Priority: Medium
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: voltha-go-controller
-
Labels:None
-
Story Points:0
https://gerrit.opencord.org/plugins/gitiles/voltha-go-controller/+/refs/heads/master/Makefile
- Add a project copyright notice spanning 2022-2024
- Remove sudo calls [target:build-docker-profile|sudo docker build -t $(IMAGENAME)-profile -f docker/Dockerfile.voltha-go-controller .]
- Jenkins does not run as a privileged user.
- Sudo can be a potential failure source for build automation.
- sudo vs not-required/account has privs – can produce variant behavior.
- https://gerrit.opencord.org/plugins/gitiles/onf-make/+/refs/heads/master/makefiles/docker/include.mk repo:onf-make/makefiles/lint/docker/
- Consider makefile refactoring.
- Most golang and docker logic is available for free from existing library makefile targets.
- Review $(is-stdin) logic in docker/include.mk. When docker is passed common flags (-it) to attach stdin, stdout & stdder – it will prevent docker from directing output where jenkins can capture it for logging:
-
is-stdin = $(shell test -t 0 && { echo '--interactive'; } )
is-stdin += --tty