Uploaded image for project: 'VOLTHA'
  1. VOLTHA
  2. VOL-5289

helm chart linting problem

    XMLWordPrintable

    Details

    • Story Points:
      0

      Description

       

      Reproduction: bulk copyright edits in the

       

      % git clone https://github.com/joey-onf/copyright
      % git clone ssh://gerrit.opencord.org/voltha-helm-charts
      
      
      % cd voltha-helm-charts
      % ../copyright/gather-and-update.sh
      % make lint
      
        [ERROR] Chart modified but version unchanged: voltha-stack/Chart.yaml (?????????????????)
        [ERROR] Chart modified but version unchanged: voltha-infra/Chart.yaml (?????????????????)
      

       

      • Several charts are modified
      • Chart.yaml versions are updated for the 1st batch of lint errors reported.
      • While working through the list fixing problems, chart version displayed reports an invalid version string:
        • [ERROR] Chart modified but version unchanged: voltha-stack/Chart.yaml (?????????????????)
      • This is due to no chart delta being detected
        • Conditional fails if version_diff "$chart" "$COMPARISON_BRANCH" 'old' 'new'; then
      • The else condition attempts to obtain version by simple grep extraction:
        • get_version_by_git old "$chart" "$COMPARISON_BRANCH"
      • Charts voltha-stack, voltha-infra and voltha contain multiple version strings
      • Function get_version_by_git() becomes confused by the list so reports '????????????????'

      declare -a buffer=([0]="version    : \"2.12.8\"" [1]="    version    : \"2.12.16\"" [2]="    version    : \"2.12.3\"" [3]="    version    : \"2.12.6\"" [4]="    version    : \"0.1.4\"")

       

      To remedy the problem linting tool should be made aware of Chart.yaml syntax so it can extract the correct version string for comparison.

       

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              joey Joey Armstrong
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:

                  Gerrit Reviews

                  There are no open Gerrit changes