-
Type: Task
-
Status: To Do (View Workflow)
-
Priority: Medium
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: Unknown
-
Labels:None
-
Story Points:0
Misc edits needed to support consistent behavior across repositories:
- Remove vendor/ directory from revision control:
- augment to retrieve and install based on dependencies (existence)
- vendor/ existence in VCS contributes to a variety of problems.
- building locally, target mod-update. mod-update will remove the vendor directory as step one. If mod-update (~tidy) fails the sandbox is left in an unbuildable state due to git status showing vendor/ has been deleted (manual fix: git checkout vendor/).
- This problem disappears when vendor is removed.
- Makefile bootstrap logic should retrieve and install the vendor/ directory when it does not exist.
- update copyright notice in source to std notice (may be done already)
- run gofmt -s -w on all golang sources
- Copy in library makefiles/ logic from onf-make
- https://github.com/opencord/onf-make
- inlined docker logic contains a problem that inhibits jenkins logging container output during a job run.
- targets covered: lint, lint-dockerfile, lint-golang,
- targets pending/may already have been added in onf-make:
- lint-mod
- sca
- mod-update
- ...
Oh also several repositories share this identical problem.
Dependency logic should be library based/reusable not anchored to a single repository.