Uploaded image for project: 'VOLTHA'
  1. VOLTHA
  2. VOL-4928

repo:voltha-protos -- makefile clean target creates residue

    XMLWordPrintable

    Details

    • Type: Task
    • Status: To Do (View Workflow)
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Unknown
    • Labels:
      None
    • Story Points:
      0

      Description

      % git remote -v show

      origin  ssh://gerrit.opencord.org:29418/voltha-protos.git (fetch)
      origin  ssh://gerrit.opencord.org:29418/voltha-protos.git (push)

      The voltha-proto repository requires some bootstrapping in the form of needing a copy of golang api code, etc on disk.  A copy of the go directory has been checked in which creates a few oddities:

      • We have duplication, non-maintainable code placed under VCS.
      • The makefile clean target removes source under version control.

       

      % make clean

      % git status

      Changes not staged for commit:
       (use "git add/rm <file>..." to update what will be committed)
       (use "git restore <file>..." to discard changes in working directory)
             deleted:    go/adapter_service/adapter_service.pb.go
             deleted:    go/common/common.pb.go
             deleted:    go/core/core.pb.go
             deleted:    go/core_adapter/core_adapter.pb.go
             deleted:    go/core_service/core_services.pb.go
             deleted:    go/ext/config/ext_config.pb.go
             deleted:    go/extension/extensions.pb.go
             deleted:    go/health/health.pb.go
             deleted:    go/ietf/ietf_interfaces.pb.go
             deleted:    go/inter_adapter/inter_adapter.pb.go

       

      Another voltha-go based repository exhibited similar behavior but failed outright to build:

      % make clean

      % make

      BOOM

       

      Look into augmenting makefile target and convert the logic into a dependency.  When go/* sources do not exist checkout a tagged copy from google(s) original source repository VS copying files locally and placing them under version control allowing make to create funky sandbox state.

       

       

       

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            joey Joey Armstrong
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes