Uploaded image for project: 'VOLTHA'
  1. VOLTHA
  2. VOL-4909

voltha-openolt-adapter: NOP fails due to modified files

    XMLWordPrintable

    Details

    • Type: Task
    • Status: To Do (View Workflow)
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: openolt-agent
    • Labels:
      None
    • Story Points:
      0

      Description

      https://gerrit.opencord.org/c/voltha-openolt-adapter/+/33562

      https://jenkins.opencord.org/job/verify_voltha-openolt-adapter_unit-test-lint/2259/console

       

      A NOP patch was created that simply modified copyright notices within repository sources.

      Jenkins job initiated by the pull request failed due to modified files.

      I would suspect golang tidy failed due to linting/go tidy not being run prior to checkin.

       

      23:14:33 docker run --rm --user $(id -u):$(id -g) -v /w/workspace/verify_voltha-openolt-adapter_unit-test-lint/go/src/github.com/opencord/voltha-openolt-adapter:/app  -v gocache:/.cache -v gocache-2.4.0:/go/pkg voltha/voltha-ci-tools:2.4.0-golang go mod vendor
      23:14:34 ERROR: Modified files detected after running go mod tidy / go mod vendor
      23:14:35 HEAD detached at e54ae87
      23:14:35 Changes not staged for commit:
      23:14:35   (use "git add <file>..." to update what will be committed)
      23:14:35   (use "git checkout -- <file>..." to discard changes in working directory)
      23:14:35 
      23:14:35 	modified:   vendor/github.com/opencord/voltha-lib-go/v7/pkg/db/backend.go
      23:14:35 	modified:   vendor/github.com/opencord/voltha-lib-go/v7/pkg/db/kvstore/client.go
      23:14:35 	modified:   vendor/github.com/opencord/voltha-lib-go/v7/pkg/platform/common.go
      23:14:35 	modified:   vendor/github.com/opencord/voltha-lib-go/v7/pkg/probe/probe.go
      23:14:35 	modified:   vendor/github.com/opencord/voltha-lib-go/v7/pkg/techprofile/tech_profile_if.go
      23:14:35 	modified:   vendor/github.com/opencord/voltha-lib-go/v7/pkg/version/version.go
      23:14:35 
      23:14:35 no changes added to commit (use "git add" and/or "git commit -a")
      23:14:35 Makefile:110: recipe for target 'lint-mod' failed
      23:14:35 make: *** [lint-mod] Error 1*no* further _formatting_ is done here

       

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              joey Joey Armstrong
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:

                  Gerrit Reviews

                  There are no open Gerrit changes