Uploaded image for project: 'VOLTHA'
  1. VOLTHA
  2. VOL-4811 repo:voltha-system-tests - pylint source cleanup needed
  3. VOL-4812

voltha-system-tests: pylint libraries/DependencyLibrary.py

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: To Do (View Workflow)
    • Priority: Low
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Testing
    • Labels:
      None
    • Story Points:
      1

      Description

      https://gerrit.opencord.org/plugins/gitiles/voltha-system-tests/+/refs/heads/master/libraries/DependencyLibrary.py

       

      Make lint target is reporting syntax problems.

      % make lint

      % make lint-python

       

      source vst_venv/bin/activate && set -u && pylint libraries/DependencyLibrary.py Module DependencyLibrary
      libraries/DependencyLibrary.py:1:0: C0114: Missing module docstring (missing-module-docstring)
      libraries/DependencyLibrary.py:1:0: C0103: Module name "DependencyLibrary" doesn't conform to snake_case naming style (invalid-
      name)
      libraries/DependencyLibrary.py:20:0: C0115: Missing class docstring (missing-class-docstring)
      libraries/DependencyLibrary.py:25:8: C0103: Attribute name "ROBOT_LIBRARY_LISTENER" doesn't conform to snake_case naming style
      (invalid-name)
      libraries/DependencyLibrary.py:20:0: R0205: Class 'DependencyLibrary' inherits from object, can be safely removed from bases in
      python3 (useless-object-inheritance)
      libraries/DependencyLibrary.py:28:4: C0116: Missing function or method docstring (missing-function-docstring)
      libraries/DependencyLibrary.py:31:27: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
      libraries/DependencyLibrary.py:34:27: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
      libraries/DependencyLibrary.py:20:0: R0903: Too few public methods (1/2) (too-few-public-methods)

      ------------------------------------------------------------------
      Your code has been rated at 4.71/10 (previous run: 4.71/10, +0.00)

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            joey Joey Armstrong
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes