Uploaded image for project: 'VOLTHA'
  1. VOLTHA
  2. VOL-4737

Bug on equality check method makes Sadis unit tests pass indefinitely

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: onos-sadis
    • Labels:
      None
    • Story Points:
      1

      Description

      The method checkEquality, which is used in several unit tests, is comparing the same object instance:

      public boolean checkEquality(BaseInformation localEntry, BaseInformation entry) {
    SubscriberAndDeviceInformation sub = (SubscriberAndDeviceInformation) localEntry;
    SubscriberAndDeviceInformation other = (SubscriberAndDeviceInformation) localEntry;
[...]

       

      Once I changed it, almost all unit tests failed.

      Some adjustments on resources files are needed in order to make it work.

        Attachments

        # Subject Branch Project Status CR V
        32845,1 [VOL-4737] Fixing unit tests. master sadis Status: MERGED +2 +1

          Activity

            People

            Assignee:
            Gustavo Gustavo Silva
            Reporter:
            Gustavo Gustavo Silva
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes