-
Type:
Task
-
Status: Resolved (View Workflow)
-
Priority:
Medium
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: VOLTHA v2.9
-
Component/s: openolt-agent
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:VOLTHA 2.9 - Sprint 1
core_utils.cc:1830 the static declaration should have been static const. This is to give the compiler an opportunity to optimize the binary.
std::pair<grpc_ssl_client_certificate_request_type, bool> get_grpc_tls_option(const char* tls_option) {
static std::map<std::string,grpc_ssl_client_certificate_request_type> grpc_security_option_map = {{"GRPC_SSL_DONT_REQUEST_CLIENT_CERTIFICATE",
Better:
std::pair<grpc_ssl_client_certificate_request_type, bool> OpenOltConfig::get_tls_client_validation() {
static const std::map<std::string,grpc_ssl_client_certificate_request_type> grpc_security_option_map = {{"GRPC_SSL_DONT_REQUEST_CLIENT_CERTIFICATE",
| # | Subject | Branch | Project | Status | CR | V |
|---|---|---|---|---|---|---|
| 26223,1 | VOL-4151: Code improvement to use static const instead of static to allow for compiler optimization. Also fixed SECURITY.md document as the sample commands were not ready for copy/paste earlier. | master | openolt | Status: MERGED | +2 | +1 |
| 26522,2 | support for rlt-1600g-w and rlt-1600x-w in GPON mode | voltha-2.8 | openolt | Status: MERGED | +2 | +1 |