Broken flow-stats reply leaves flows in pending-add

Due to recent merge of ANY-VLAN functionality (most likely https://gerrit.opencord.org/#/c/17722/5/ofagent/converter.py)

it seems there is now a problem with flow-stats request. We see this exception in ofagent

 
20200304T000744.473 ERROR of_protocol_handler.handle_flow_stats_request

{req: <loxi.of13.message.flow_stats_request object at 0x7f7487eeefd0>, event: failed-flow-stats-request, exception: Traceback (most recent call last): File "/ofagent/ofagent/of_protocol_handler.py", line 263, in handle_flow_stats_request xid=req.xid, entries=[to_loxi(f) for f in flow_stats])) File "/ofagent/ofagent/converter.py", line 48, in to_loxi return converter(grpc_object) File "/ofagent/ofagent/converter.py", line 208, in ofp_flow_stats_to_loxi_flow_stats kw['match'] = make_loxi_match(kw['match']) File "/ofagent/ofagent/converter.py", line 143, in make_loxi_match loxi_match_fields.append(make_loxi_field(oxm_field)) File "/ofagent/ofagent/converter.py", line 104, in make_loxi_field if ofb_field.get('vlan_vid') == RESERVED_TRANSPARENT_VLAN and ofb_field['vlan_vid_mask'] == RESERVED_TRANSPARENT_VLAN:     It is due to  *KeyError: 'vlan_vid_mask', instance_id: voltha-ofagent-74cffcb78-vs2wr}

*

 

With a missed flow-stats-reply to ONOS, unfortunately the latter no longer sends any flow-stats requests (which is not good logic in ONOS TBH) and so flows stay in PENDING_ADD

This is seen when add_subscriber call is made with AT&T workflow