-
Type: Bug
-
Status: Resolved (View Workflow)
-
Priority: Medium
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: SEBA-Next
-
Component/s: NEM
-
Labels:None
-
Story Points:5
-
Epic Link:
Use Makefile in one of the voltha projects as an example, for example: https://github.com/opencord/voltha-go/blob/master/Makefile
It implements several useful targets:
- help
- lint (lint-sanity, lint-style, lint-dockerfile)
- sca
- test
These can then be integrated with Jenkins to perform additional code quality checks. In the course of implementing these, some issues may pop up, for example SCA violations. Fix as necessary.
Errors encountered and fixed for lint-dockerfile
root@ip-10-5-1-11:~/cord/device-management# make lint
Running style check...
Style check OK
Running Dockerfile lint check ...
./Dockerfile:24 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
./Dockerfile:24 DL3015 Avoid additional packages by specifying `--no-install-recommends`
./Dockerfile:31 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
./Dockerfile:35 SC2086 Double quote to prevent globbing and word splitting.
Makefile:56: recipe for target 'lint-dockerfile' failed
make: *** [lint-dockerfile] Error 1
# | Subject | Branch | Project | Status | CR | V |
---|---|---|---|---|---|---|
16261,3 | [SEBA-880]Ensure Redfish importer Makefile conforms to typical targets | master | device-management | Status: MERGED | +2 | +1 |