[CORD-2921] imagebuilder dies if no labels in dockerfile - OpenCORD JIRA

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Low
Resolution: Won't Fix
Affects Version/s: None
Fix Version/s: None
Component/s: imagebuilder
Labels:
None

Story Points:
2

Description

Creating an image with imagebuilder when no labels are present in the image, on second build it fails with this error (can't compare?)

INFO:__main__:Preexisting Image - ID: sha256:c3b173617a83d8ae60240f9220e88fdda6c38c00737d67a23235505d58c962ad, tags: xosproject/xos-api-tester:candidate
Traceback (most recent call last):
  File "scripts/imagebuilder.py", line 1438, in <module>
    db = DockerBuilder(rm)
  File "scripts/imagebuilder.py", line 853, in __init__
    self.find_preexisting()
  File "scripts/imagebuilder.py", line 909, in find_preexisting
    good_labels = image.compare_labels(pe_image['Labels'])
  File "scripts/imagebuilder.py", line 498, in compare_labels
    if label in other_labels and \
TypeError: argument of type 'NoneType' is not iterable

Found by Andy Bavier when working on the containerized xos-api-test

Attachments

Options
- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

Gerrit Reviews

No reviews matched the request. Check your Options in the drop-down menu of this sections header.

Activity

People

Assignee:: Zack Williams

Reporter:: Zack Williams

Watchers:: 1 Start watching this issue

Dates

Created:: 2018/04/09 4:44 PM

Updated:: 2019/06/07 10:58 AM

Resolved:: 2019/06/07 10:58 AM

Gerrit Reviews

There are no open Gerrit changes