-
Type: Bug
-
Status: Resolved (View Workflow)
-
Priority: Medium
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: Fabric
-
Labels:None
-
Story Points:3
This is observed in onos-1.12. See https://jira.onosproject.org/browse/ONOS-7591 for details of the cause.
From Saurav:
A unidirectional link shows up on spine of:101/8 pointing to of:1/1
msec later it another link shows up pointing to the correct of:5/1
2018-04-03 23:59:42,281 | INFO | gManager-event-0 | LinkHandler | 180 | ** LINK ADDED DefaultLink{src=of:0000000000000101/8, dst=of:0000000000000001/1, type=DIRECT, state=ACTIVE, expected=false} 2018-04-03 23:59:42,281 | INFO | gManager-event-0 | DefaultGroupHandler | 180 | * portUpForLink: Device of:0000000000000101 linkUp at local port 8 to neighbor of:0000000000000001 2018-04-03 23:59:42,281 | DEBUG | gManager-event-0 | DefaultGroupHandler | 180 | Device of:0000000000000101 addNeighborAtPort: neighbor of:0000000000000001 at port 8 2018-04-03 23:59:42,281 | DEBUG | gManager-event-0 | LinkHandler | 180 | Link not bidirectional.. waiting for other direction src of:0000000000000001/1 --> dst of:0000000000000101/8 2018-04-03 23:59:42,285 | INFO | gManager-event-0 | LinkHandler | 180 | ** LINK ADDED DefaultLink{src=of:0000000000000101/8, dst=of:0000000000000005/1, type=DIRECT, state=ACTIVE, expected=false}
While we do not process these unidirectional links right now, we do update some stores – the effects of which is seen later when we create buckets.
Later the reverse direction of the correct link also shows up
2018-04-03 23:59:45,249 | INFO | gManager-event-0 | LinkHandler | 180 | ** LINK ADDED DefaultLink{src=of:0000000000000005/1, dst=of:0000000000000101/8, type=DIRECT, state=ACTIVE, expected=false}
Finally the incorrect unidirectional link gets removed, but by this time the damage is done
2018-04-03 23:59:57,019 | INFO | gManager-event-0 | LinkHandler | 180 | ** LINK REMOVED DefaultLink{src=of:0000000000000101/8, dst=of:0000000000000001/1, type=DIRECT, state=ACTIVE, expected=false}
We need protect ourselves from fake links better.